Code commits

qt-openzwave

OpenZwave - Master Repository

nechry <nechry@gmail.com> 30 Dec 2019 71220f433d1568cca725ff45885e7b9cd90381b6

Bump version
- config/aeotec/zwa021.xml (version 71220f433d1568cca725ff45885e7b9cd90381b6) (diffs)
- cpp/build/testconfigversions.cfg (version 71220f433d1568cca725ff45885e7b9cd90381b6) (diffs)
Jean-François Auger <nechry@gmail.com> 30 Dec 2019 ff539ee57f4671612c007114008f4a99ebe80a5e

Add new device Aeotec zwa021 Thermostatic Valve (#2051)

Add new device Aeotec zwa021 Thermostatic Valve
Jean-François Auger <nechry@gmail.com> 30 Dec 2019 de266a1804059ca0ca6984e6702c8c0f69a24010

Update zwa021.xml
- config/aeotec/zwa021.xml (version de266a1804059ca0ca6984e6702c8c0f69a24010) (diffs)
Jean-François Auger <nechry@gmail.com> 29 Dec 2019 f80ffea298032034c40cc3b79769d4df49179404

Reformat and remove small typo
- config/qubino/ZMNHQDx.xml (version f80ffea298032034c40cc3b79769d4df49179404) (diffs)
Ben Van Mechelen <ben@benvm.be> 27 Dec 2019 607dd7a931f20a747812d3009a9a51cb7db55f6a

Add new device Aeotec zwa021 Thermostatic Valve
- config/aeotec/zwa021.xml (version 607dd7a931f20a747812d3009a9a51cb7db55f6a) (diffs)
- config/images/aeotec/zwa021.png (version 607dd7a931f20a747812d3009a9a51cb7db55f6a) (diffs)
- config/manufacturer_specific.xml (version 607dd7a931f20a747812d3009a9a51cb7db55f6a) (diffs)
- cpp/build/testconfigversions.cfg (version 607dd7a931f20a747812d3009a9a51cb7db55f6a) (diffs)
Younes Manton <926840+ymanton@users.noreply.github.com> 26 Dec 2019 009f887250dac2ad393a8ebe87d43c8cbf23399f

Add fibaro flood sensor (#2050)

* Add Fibaro flood sensor id=2003

* Update distfiles.mk for Kwikset Convert 914
- config/manufacturer_specific.xml (version 009f887250dac2ad393a8ebe87d43c8cbf23399f) (diffs)
- cpp/build/testconfigversions.cfg (version 009f887250dac2ad393a8ebe87d43c8cbf23399f) (diffs)
- distfiles.mk (version 009f887250dac2ad393a8ebe87d43c8cbf23399f) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 26 Dec 2019 dd9c9f59713d6da595eaa82c62f1e89b6d7153f4

Fix a possible infinite loop with invalid list configuration data (#2047)

Before this commit, it is possible to have an infinite loop and log filling with:

"Warning, Item value is wrong type or does not exist in xml configuration for node 9, class 0x70, instance 1, index 1"

This is because the code skipped "itemElement = itemElement->NextSiblingElement();"

IMHO only happens with corrupt or edited ozwcache file.
- cpp/src/value_classes/ValueList.cpp (version dd9c9f59713d6da595eaa82c62f1e89b6d7153f4) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 26 Dec 2019 4d1d4427dba559700398a1eb250f2eaac8912610

Add ValueID::GetAsString() for debugging purposes (#2040)

* Add ValueID::GetAsString() for debugging purposes

This function allows to convert a valueID to human readable form

Example (from tests):

ValueID(static_cast<uint64>(0x1), 0x02, ValueID::ValueGenre_System, 0x04, 5, 6, ValueID::ValueType_String).GetAsString()

"HomeID: 0x00000001, ValueID: (Id 0x0006000002c10057, NodeID 2, Genre system, CC 0x04, Instance 5, Index 6, Type string)"

Related to https://github.com/OpenZWave/open-zwave/issues/2038 "Ozwcache corruption leading to memory corruption and crash"

* Add Log to Node::GetValue in case retrieved ID does not match request ID

* no need to introduce a namespace

Co-authored-by: Justin Hammond <justin@dynam.ac>
- cpp/src/Node.cpp (version 4d1d4427dba559700398a1eb250f2eaac8912610) (diffs)
- cpp/src/value_classes/ValueID.cpp (version 4d1d4427dba559700398a1eb250f2eaac8912610) (diffs)
- cpp/src/value_classes/ValueID.h (version 4d1d4427dba559700398a1eb250f2eaac8912610) (diffs)
- cpp/test/ValueID_test.cpp (version 4d1d4427dba559700398a1eb250f2eaac8912610) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 26 Dec 2019 a53dde3db58daff140ffe28417c0c6d9a567d62e

Call CheckCompletedNodeQueries in MoveMessagesToWakeUpQueue (#2034)

If a network consists of sleeping nodes (and they sleep) none of the notifications Type_AwakeNodesQueried Type_AllNodesQueriedSomeDead Type_AllNodesQueried is send because all messages are moved to the wake up queue.

Reported by Gilles Printemps, https://groups.google.com/d/msg/openzwave/THGYQ1jqKF4/cZPF5FEDBQAJ
- cpp/src/Driver.cpp (version a53dde3db58daff140ffe28417c0c6d9a567d62e) (diffs)
Matej Drobnič <matejdro@gmail.com> 26 Dec 2019 39d925483d935c8d44e3f8dfe1eccbfdfcd9c63c

Make set after get optional - Fixed version (#2010)

* Make set after get optional

* Fix duplicate method name

# Conflicts:
# cpp/src/value_classes/Value.h

* Fix whitespace

* Change to use CompatOption's instead

Co-authored-by: Peter Gebruers <peter.gebruers@gmail.com>
Co-authored-by: Justin Hammond <justin@dynam.ac>
- config/device_configuration.xsd (version 39d925483d935c8d44e3f8dfe1eccbfdfcd9c63c) (diffs)
- cpp/src/CompatOptionManager.cpp (version 39d925483d935c8d44e3f8dfe1eccbfdfcd9c63c) (diffs)
- cpp/src/CompatOptionManager.h (version 39d925483d935c8d44e3f8dfe1eccbfdfcd9c63c) (diffs)
- cpp/src/command_classes/CommandClass.cpp (version 39d925483d935c8d44e3f8dfe1eccbfdfcd9c63c) (diffs)
- cpp/src/value_classes/Value.cpp (version 39d925483d935c8d44e3f8dfe1eccbfdfcd9c63c) (diffs)
- cpp/src/value_classes/Value.h (version 39d925483d935c8d44e3f8dfe1eccbfdfcd9c63c) (diffs)
- cpp/src/value_classes/ValueStore.cpp (version 39d925483d935c8d44e3f8dfe1eccbfdfcd9c63c) (diffs)
Chanse Arrington <chanse.arrington@gmail.com> 23 Dec 2019 c78eddf6f1b61fc15ac3ccff4a828802ad9c7337

Update ge zw6302 and add manufacturer "Ring" (#2046) (#2041)

Co-authored-by: Peter Gebruers <peter.gebruers@gmail.com>
- config/ge/zw6302.xml (version c78eddf6f1b61fc15ac3ccff4a828802ad9c7337) (diffs)
- config/manufacturer_specific.xml (version c78eddf6f1b61fc15ac3ccff4a828802ad9c7337) (diffs)
- cpp/build/testconfigversions.cfg (version c78eddf6f1b61fc15ac3ccff4a828802ad9c7337) (diffs)
- dist/openzwave.spec (version c78eddf6f1b61fc15ac3ccff4a828802ad9c7337) (diffs)
jeffsanicola <51798085+jeffsanicola@users.noreply.github.com> 23 Dec 2019 30634567ed2cc90f78c9583a819a1e855f5c4990

Update Kwikset Convert 914 (#2043)

Co-authored-by: Peter Gebruers <peter.gebruers@gmail.com>
- config/images/kwikset/914c.png (version 30634567ed2cc90f78c9583a819a1e855f5c4990) (diffs)
- config/kwikset/914c.xml (version 30634567ed2cc90f78c9583a819a1e855f5c4990) (diffs)
- config/manufacturer_specific.xml (version 30634567ed2cc90f78c9583a819a1e855f5c4990) (diffs)
- cpp/build/testconfigversions.cfg (version 30634567ed2cc90f78c9583a819a1e855f5c4990) (diffs)
jeffsanicola <51798085+jeffsanicola@users.noreply.github.com> 09 Dec 2019 76e21d80a140c321413a46a2b62ea6c11dd6ace0

Add Kwikset Convert 914 (#2032)

Add Kwikset Convert 914 to manufacturer_specific.xml
- config/manufacturer_specific.xml (version 76e21d80a140c321413a46a2b62ea6c11dd6ace0) (diffs)
- cpp/build/testconfigversions.cfg (version 76e21d80a140c321413a46a2b62ea6c11dd6ace0) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 09 Dec 2019 e7acd13789a52a1d08e029eaea19c1c46cef2a44

Merge pull request #2031 from radovanbauer/master

Added config for GE (Jasco) 46203 In-Wall Smart Dimmer.
Radovan Bauer <radovan.bauer@gmail.com> 08 Dec 2019 52c34c342b45346a5cb921060a2d087a0b657b83

Added config for GE (Jasco) 46203 In-Wall Smart Dimmer.
This is the 2nd gen of the dimmer wih QuickFit and SimpleWire enhancements.

This configuration is based on the xml spec from
https://products.z-wavealliance.org/products/3323 . I have tested all
configuration parameters on an actual switch.
- config/ge/46203-dimmer.xml (version 52c34c342b45346a5cb921060a2d087a0b657b83) (diffs)
- config/images/ge/46203-dimmer.png (version 52c34c342b45346a5cb921060a2d087a0b657b83) (diffs)
- config/manufacturer_specific.xml (version 52c34c342b45346a5cb921060a2d087a0b657b83) (diffs)
- cpp/build/testconfigversions.cfg (version 52c34c342b45346a5cb921060a2d087a0b657b83) (diffs)
- distfiles.mk (version 52c34c342b45346a5cb921060a2d087a0b657b83) (diffs)
Keith Pine <keith.pine@gmail.com> 07 Dec 2019 9526554bdffd9e2049b3e9ad1ab0d119fdb9595f

config CT32: correct instance/endpoint mapping (#2027)

Enable mapping root to endpoint. The root and endpoint 1 seem to have
identical functionality. Enabling this mapping removes the duplicate
values (battery, setpoint, etc).

Temperature and humidity are still duplicated since those are provided
by endpoint 2 as well.
- config/2gig/ct32.xml (version 9526554bdffd9e2049b3e9ad1ab0d119fdb9595f) (diffs)
- cpp/build/testconfigversions.cfg (version 9526554bdffd9e2049b3e9ad1ab0d119fdb9595f) (diffs)
- distfiles.mk (version 9526554bdffd9e2049b3e9ad1ab0d119fdb9595f) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 07 Dec 2019 82596acd91b16ea621a586f459d613937bba0f59

Updates to "OZW revision" (git describe) script on Unix (#2028)

Potential fix for git version "dirty" flag.
Might help diagnose "revision on build server always 1.6.0".

When entering support.mk a second time, git describe returns "dirty" flag although I saw no immediate cause.

According to the docs, --git-dir should be used with --work-tree, or use the -C flag, introduced in git 1.8.5-ish.

Added debugging (Makefile warnings).

Tested on macOS Catalina and Debian 8 (Jessie), released 25–26 April 2015. Not tested on Debian 7 (Wheezy), released 4 May 2013 because it does not come with C++11 compiler by default.
- cpp/build/support.mk (version 82596acd91b16ea621a586f459d613937bba0f59) (diffs)
- dist/openzwave.spec (version 82596acd91b16ea621a586f459d613937bba0f59) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 07 Dec 2019 f598fdc387e6a8cd7d1bb077d7f1058ef08229df

Make flock(m_hSerialController... actually do something (#2026)

Previously we will still try to continue if we couldn't get a LOCK on the serial port. Now we bail out and go into a loop trying to get the Lock.
- cpp/src/platform/unix/SerialControllerImpl.cpp (version f598fdc387e6a8cd7d1bb077d7f1058ef08229df) (diffs)
Justin Hammond 05 Dec 2019 3aad04a766d5bf63cdf2935bb8edd5664ecd0335

Merge pull request #2023 from petergebruers/master
Justin Hammond 05 Dec 2019 6c3939ae2106ac7d2fb7439ac6df46600948d649

Merge pull request #2024 from petergebruers/mc_aftermark
Peter Gebruers <peter.gebruers@gmail.com> 05 Dec 2019 6305bbac6c70c3a3b3b974cb105d7485a3591860

Don't request Instances is Multichannel is "after mark"

IMHO if the Multichannel CC is net before, but only after the "mark" then the device is not multi channel.

Adds log:

2019-12-05 10:34:57.454 Detail, Node004, Skipping RequestInstances() because MultiChannel CC is "after mark"

Fixes "Problems with ZME_WALLC-S after Update from 1.4 to 1.6 - states missing" #2020 by not doing 17 requests that all time out...
- cpp/src/Node.cpp (version 6305bbac6c70c3a3b3b974cb105d7485a3591860) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 05 Dec 2019 37c8e2b590c604d4c1cf7fbbd485fd3d8ac891ee

Fix comparison uint8 with -1, also test if controller node is 0.

lldb complained:
Driver.cpp:2701:43: error:
      result of comparison of constant -1 with expression of type
      'uint8' (aka 'unsigned char') is always false
      [-Werror,-Wtautological-constant-out-of-range-compare]

Add some info to debug logging
- cpp/src/Driver.cpp (version 37c8e2b590c604d4c1cf7fbbd485fd3d8ac891ee) (diffs)
Justin Hammond 02 Dec 2019 ac5043ece9b65096caaabba4b9b820cc5a1170b1

Need to return from here
- cpp/src/Driver.cpp (version ac5043ece9b65096caaabba4b9b820cc5a1170b1) (diffs)
Justin Hammond 02 Dec 2019 b567ce0fb3b8733a139e4f49908bf05b7cdfb679

Refuse to add 255 as a NodeID to any Association. Issue #1883
- cpp/src/Group.cpp (version b567ce0fb3b8733a139e4f49908bf05b7cdfb679) (diffs)
Justin Hammond 02 Dec 2019 f44387718c9f9509e410dc9c3e8be1aa2b0a5a74

Serialize the Initilization Sequence, and Bail out if we have a invalid HomeID or Controller NodeID - Relates to issue #1883
- cpp/src/Driver.cpp (version f44387718c9f9509e410dc9c3e8be1aa2b0a5a74) (diffs)
- cpp/src/platform/Controller.cpp (version f44387718c9f9509e410dc9c3e8be1aa2b0a5a74) (diffs)
- cpp/src/platform/Controller.h (version f44387718c9f9509e410dc9c3e8be1aa2b0a5a74) (diffs)
Olifant1990 <25199588+Olifant1990@users.noreply.github.com> 02 Dec 2019 687f6b2fc48e5be5943c7b36e47a99d81d8483e0

BeNext P1 Updated to new template (#2021)

* Updated to new template

* make xmltest
- config/BeNext/P1dongle.xml (version 687f6b2fc48e5be5943c7b36e47a99d81d8483e0) (diffs)
- cpp/build/testconfigversions.cfg (version 687f6b2fc48e5be5943c7b36e47a99d81d8483e0) (diffs)
Justin Hammond 29 Nov 2019 81816f1c36f891428abc9f8a3090bf8fc0a79e1c

Merge branch 'master' of https://github.com/OpenZWave/open-zwave
Justin Hammond 29 Nov 2019 862a4a981acbdeb3c3e9dc72faeb2507321be21d

Potential fix for issue #2018 - Avoid getting stuck in a loop when querying association group memberships
- cpp/src/command_classes/Association.cpp (version 862a4a981acbdeb3c3e9dc72faeb2507321be21d) (diffs)
- cpp/src/command_classes/Association.h (version 862a4a981acbdeb3c3e9dc72faeb2507321be21d) (diffs)
- cpp/src/command_classes/MultiChannelAssociation.cpp (version 862a4a981acbdeb3c3e9dc72faeb2507321be21d) (diffs)
- cpp/src/command_classes/MultiChannelAssociation.h (version 862a4a981acbdeb3c3e9dc72faeb2507321be21d) (diffs)
Justin Hammond 29 Nov 2019 47d61dc9e79f42963edf76d607a5396e75e3ee93

Potential fix for issue #2108 - Avoid getting stuck in a loop when querying association group memberships
- cpp/src/command_classes/Association.cpp (version 47d61dc9e79f42963edf76d607a5396e75e3ee93) (diffs)
- cpp/src/command_classes/Association.h (version 47d61dc9e79f42963edf76d607a5396e75e3ee93) (diffs)
- cpp/src/command_classes/MultiChannelAssociation.cpp (version 47d61dc9e79f42963edf76d607a5396e75e3ee93) (diffs)
- cpp/src/command_classes/MultiChannelAssociation.h (version 47d61dc9e79f42963edf76d607a5396e75e3ee93) (diffs)
Justin Hammond 29 Nov 2019 b7adb8788155c115c55ddfb96f9023b9a500d3d8

Fix issue #2017 - ManufacturerSpecific CC isn't applicable on instances other than root
- cpp/src/command_classes/ManufacturerSpecific.cpp (version b7adb8788155c115c55ddfb96f9023b9a500d3d8) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 27 Nov 2019 e89d2a1677f5afe74e836d8c75d7f33d784ea790

Add PAN06-1 In Wall Dual Relay with id 0x13, PR #2014
- config/manufacturer_specific.xml (version e89d2a1677f5afe74e836d8c75d7f33d784ea790) (diffs)
- cpp/build/testconfigversions.cfg (version e89d2a1677f5afe74e836d8c75d7f33d784ea790) (diffs)
Justin Hammond 25 Nov 2019 b88f216fbff3f4e1354f183b1904186e06b1c78a

fix up GetCommandClassName
- cpp/src/Manager.cpp (version b88f216fbff3f4e1354f183b1904186e06b1c78a) (diffs)
Justin Hammond 25 Nov 2019 c407cce268047f304d6b821d8aff57d3c8083a24

Merge branch 'master' of https://github.com/OpenZWave/open-zwave
Justin Hammond 25 Nov 2019 e2c5fae7600790a8cc376b905ef0775313f330e5

Expose a function to get the CommandClass Name
- cpp/src/Manager.cpp (version e2c5fae7600790a8cc376b905ef0775313f330e5) (diffs)
- cpp/src/Manager.h (version e2c5fae7600790a8cc376b905ef0775313f330e5) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 25 Nov 2019 3a4bef4a0adbde8efe9038b03e348e6aaeb5baf8

Add message details to log of dropped message (#2011)

Before PR

Node002, ERROR: Dropping command, expected response not received after 1 attempt(s).

After PR

ode002, ERROR: Dropping command, expected response not received after 1 attempt(s). Command: "SensorMultilevelCmd_Get (Node=2): 0x01, 0x0b, 0x00, 0x13, 0x02, 0x04, 0x31, 0x04, 0x01, 0x00, 0x25, 0x20, 0xd0"
- cpp/src/Driver.cpp (version 3a4bef4a0adbde8efe9038b03e348e6aaeb5baf8) (diffs)
- dist/openzwave.spec (version 3a4bef4a0adbde8efe9038b03e348e6aaeb5baf8) (diffs)
Justin Hammond 25 Nov 2019 a335d2cd43be20d5fa2c0dc367c6a1287d825073

Expose String Representations for Basic, Generic and Specific Device Classes and Also Expose Generic/Specific DeviceClasses for each instance
- cpp/src/Driver.cpp (version a335d2cd43be20d5fa2c0dc367c6a1287d825073) (diffs)
- cpp/src/Driver.h (version a335d2cd43be20d5fa2c0dc367c6a1287d825073) (diffs)
- cpp/src/Manager.cpp (version a335d2cd43be20d5fa2c0dc367c6a1287d825073) (diffs)
- cpp/src/Manager.h (version a335d2cd43be20d5fa2c0dc367c6a1287d825073) (diffs)
- cpp/src/Node.cpp (version a335d2cd43be20d5fa2c0dc367c6a1287d825073) (diffs)
- cpp/src/Node.h (version a335d2cd43be20d5fa2c0dc367c6a1287d825073) (diffs)
- cpp/src/command_classes/MultiInstance.cpp (version a335d2cd43be20d5fa2c0dc367c6a1287d825073) (diffs)
- cpp/src/command_classes/MultiInstance.h (version a335d2cd43be20d5fa2c0dc367c6a1287d825073) (diffs)
- dist/openzwave.spec (version a335d2cd43be20d5fa2c0dc367c6a1287d825073) (diffs)
Justin Hammond 25 Nov 2019 027d7436cc47ab99f3f07009a89403e66a1fd9c3

Check if MultiChannel is present on a device before tring to add a MCA with a instance, otherwise fall back to plan associations - Issue #1895
- cpp/src/Group.cpp (version 027d7436cc47ab99f3f07009a89403e66a1fd9c3) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 25 Nov 2019 117cff5cfcbc0327acbc58f75dfcedca5d24beaf

Fix SensorBinary V1 decoding (#2006)

I noticed bogus Binary Sensor numbers in the log, for example:

Node002, Received SensorBinary report: Sensor:199 State=On

Based on serial frame:

Received: 0x01, 0x0b, 0x00, 0x04, 0x00, 0x02, 0x03, 0x30, 0x03, 0xff, 0xc7, 0x00, 0xfa

Length of the CC is 0x03, payload is 0x30, 0x03, 0xff, so OZW mistakenly takes next byte as "Sensor Type"

The length test was off by one.

After this patch:

Node002, Received SensorBinary report: State=On

V2 reports still work:

Received: 0x01, 0x0a, 0x00, 0x04, 0x00, 0x02, 0x04, 0x30, 0x03, 0xff, 0x0c, 0x37

Node002, Received SensorBinary report: Sensor:12 State=On
- cpp/src/command_classes/SensorBinary.cpp (version 117cff5cfcbc0327acbc58f75dfcedca5d24beaf) (diffs)
Justin Hammond 25 Nov 2019 be3491ed9a5153b73098846107c2e70b9630cb1f

Revert "Make set after get optional" (#2009)
- cpp/src/value_classes/Value.cpp (version be3491ed9a5153b73098846107c2e70b9630cb1f) (diffs)
- cpp/src/value_classes/Value.h (version be3491ed9a5153b73098846107c2e70b9630cb1f) (diffs)
Justin Hammond 25 Nov 2019 c4587989d85ee3ba360175bc7e2c09ef2911c4c7

Merge pull request #2008 from matejdro/optional_get_after_set
Matej Drobnič <matejdro@gmail.com> 25 Nov 2019 f919e656fba30cef540f86ffe1448301c48d50aa

Make set after get optional
- cpp/src/value_classes/Value.cpp (version f919e656fba30cef540f86ffe1448301c48d50aa) (diffs)
- cpp/src/value_classes/Value.h (version f919e656fba30cef540f86ffe1448301c48d50aa) (diffs)
Justin Hammond 21 Nov 2019 8d0684935389453fc26723306e7f2e453b7fa892

Create PRTest.yml
- .github/workflows/PRTest.yml (version 8d0684935389453fc26723306e7f2e453b7fa892) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 17 Nov 2019 cbe2b60f9470a5552336748719a18390457fc97b

Fix config parameter 68 in ZMNHDDX.xml #1995 (#2001)
- config/qubino/ZMNHDDx.xml (version cbe2b60f9470a5552336748719a18390457fc97b) (diffs)
- cpp/build/testconfigversions.cfg (version cbe2b60f9470a5552336748719a18390457fc97b) (diffs)
Justin Hammond 16 Nov 2019 c1d50897964bf19f7992026bfb73e0b5eea12846

Update DistFiles
- distfiles.mk (version c1d50897964bf19f7992026bfb73e0b5eea12846) (diffs)
Jean-François Auger <nechry@gmail.com> 15 Nov 2019 4b8830b0bfda33bf1b410cc6707b2fd486003f29

Update manufacturer_specific.xml

bump revision
- config/manufacturer_specific.xml (version 4b8830b0bfda33bf1b410cc6707b2fd486003f29) (diffs)
Jean-François Auger <nechry@gmail.com> 15 Nov 2019 2fc88c541377231c63654682a9e7abb9eec154a4

Merge pull request #2000 from gizmocuz/mcohome-a89-addtypea803

Added A803 type to MCOHome a8/9 product
Jean-François Auger <nechry@gmail.com> 15 Nov 2019 58fba43f23d6a6bf951ed5c9ef7d90c84345710b

bump revision

bump revision
- config/manufacturer_specific.xml (version 58fba43f23d6a6bf951ed5c9ef7d90c84345710b) (diffs)
Jean-François Auger <nechry@gmail.com> 15 Nov 2019 1b0f365793ec8d94bbf19b65e7845ff329faf93d

Merge pull request #1999 from GiuseppeWidom/master

Added config file WiDom Smart Dry Contact
Rob Peters <ROb@DVBControl.com> 15 Nov 2019 2ef646ad263ebcc58a95ce1283153315b080f11e

Added A803 type to MCOHome a8/9 product
- config/manufacturer_specific.xml (version 2ef646ad263ebcc58a95ce1283153315b080f11e) (diffs)
Giuseppe Tiddia 15 Nov 2019 405e48646a2e771d5d4cbf1233dd675a4ce9e0ae

Added config file WiDom Smart Dry Contact. File config/widom/DRY.xml. Added new device in manufacturer_specific.xml: config=widom/DRY.xml, id=0900, name=DRY Smart Dry Contact Switch, type=1214
- config/manufacturer_specific.xml (version 405e48646a2e771d5d4cbf1233dd675a4ce9e0ae) (diffs)
- config/widom/DRY.xml (version 405e48646a2e771d5d4cbf1233dd675a4ce9e0ae) (diffs)
- cpp/build/testconfigversions.cfg (version 405e48646a2e771d5d4cbf1233dd675a4ce9e0ae) (diffs)
Peter Gebruers 13 Nov 2019 aa29b66ea61f1226bb96dc6717861afd819d843c

Make GetValueStoreKey public and add tests (#1997)

No functional changes.

GetValueStoreKey has 2 overloads and they return identical results, the math is correct, this was questioned here: https://github.com/domoticz/domoticz/issues/3727
- cpp/src/value_classes/ValueID.h (version aa29b66ea61f1226bb96dc6717861afd819d843c) (diffs)
- cpp/test/ValueID_test.cpp (version aa29b66ea61f1226bb96dc6717861afd819d843c) (diffs)
- dist/openzwave.spec (version aa29b66ea61f1226bb96dc6717861afd819d843c) (diffs)
gizmocuz <gizmocuz@users.noreply.github.com> 12 Nov 2019 79663e1e50d2f2f4ea7a02e7768a71d70b24438e

Making GetValue code more consistent, Releasing values (#1985)

* Making GetValue code more persistent throughout application, releasing values
* Removed duplicate item declaration
* Add "else" parts and comment
- cpp/src/command_classes/ClimateControlSchedule.cpp (version 79663e1e50d2f2f4ea7a02e7768a71d70b24438e) (diffs)
Peter Gebruers 11 Nov 2019 a06ee56c0c332f7d593f516dca78cf11418c04d4

update gtest to Nov 5, 2019 version (commit e08a460) (#1994)

Aka Release 1.10.x
This version would allow the use of GoogleMock but that part has not been imported, only the GoogleTest headers and cpp files have been updated.
Based on C++11
- cpp/test/include/gtest/gtest-death-test.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest-matchers.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest-message.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest-param-test.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest-param-test.h.pump (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest-printers.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest-spi.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest-test-part.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest-typed-test.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest_pred_impl.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/gtest_prod.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/custom/README.md (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/custom/gtest-port.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/custom/gtest-printers.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/custom/gtest.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-death-test-internal.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-filepath.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-internal.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-linked_ptr.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-param-util-generated.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-param-util-generated.h.pump (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-param-util.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-port-arch.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-port.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-string.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-tuple.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-tuple.h.pump (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-type-util.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/include/gtest/internal/gtest-type-util.h.pump (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/src/gtest-death-test.cc (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/src/gtest-filepath.cc (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/src/gtest-internal-inl.h (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/src/gtest-matchers.cc (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/src/gtest-port.cc (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/src/gtest-printers.cc (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/src/gtest-test-part.cc (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/src/gtest-typed-test.cc (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/src/gtest.cc (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- cpp/test/src/gtest_main.cc (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- dist/openzwave.spec (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
- distfiles.mk (version a06ee56c0c332f7d593f516dca78cf11418c04d4) (diffs)
Justin Hammond 11 Nov 2019 bbaad989444df82e7fd8d1f7a9060efc0b141621

Make sure we will reload our device_classes.xml on a subsequent start of the Manager Class later. Unlikely but.... Related to #1996
- cpp/src/Manager.cpp (version bbaad989444df82e7fd8d1f7a9060efc0b141621) (diffs)
Justin Hammond 11 Nov 2019 71051991af51efe18d1c7c1d2e3cfe7dba0f3a69

issue #1996 - Duplicate Entries in device_classes.xml and warn in future if we have duplicate entries
- config/device_classes.xml (version 71051991af51efe18d1c7c1d2e3cfe7dba0f3a69) (diffs)
- cpp/src/Node.cpp (version 71051991af51efe18d1c7c1d2e3cfe7dba0f3a69) (diffs)
Justin Hammond 08 Nov 2019 8a6972db6e192eefe689188b84fc05a29c9fc616

update dist files
- dist/openzwave.spec (version 8a6972db6e192eefe689188b84fc05a29c9fc616) (diffs)
- distfiles.mk (version 8a6972db6e192eefe689188b84fc05a29c9fc616) (diffs)
nechry <nechry@gmail.com> 06 Nov 2019 9cdfa101f3086c4c1b4317b85294c710e92e6d77

add new aeotec device zw187 and zw189

ZW187 Recessed Door Sensor 7
ZW189 Range Extender 7
- config/aeotec/zw187.xml (version 9cdfa101f3086c4c1b4317b85294c710e92e6d77) (diffs)
- config/aeotec/zw189.xml (version 9cdfa101f3086c4c1b4317b85294c710e92e6d77) (diffs)
- config/images/aeotec/zw187.png (version 9cdfa101f3086c4c1b4317b85294c710e92e6d77) (diffs)
- config/images/aeotec/zw189.png (version 9cdfa101f3086c4c1b4317b85294c710e92e6d77) (diffs)
- config/manufacturer_specific.xml (version 9cdfa101f3086c4c1b4317b85294c710e92e6d77) (diffs)
- cpp/build/testconfigversions.cfg (version 9cdfa101f3086c4c1b4317b85294c710e92e6d77) (diffs)
Jean-François Auger <nechry@gmail.com> 29 Oct 2019 c064eca00ffaf3ceac552a6196daa461edb72348

update Zooz ZEN26 and ZEN27 switches to latest firmware (#1989)

update Zooz ZEN26 and ZEN27 switches to latest firmware
David Alden <dave@alden.name> 24 Oct 2019 dd08931adf98b50a6442ff1fd43f371618db5de5

update Zooz ZEN26 and ZEN27 switches to latest firmware
- config/images/zooz/zen27.png (version dd08931adf98b50a6442ff1fd43f371618db5de5) (diffs)
- config/zooz/zen26.xml (version dd08931adf98b50a6442ff1fd43f371618db5de5) (diffs)
- config/zooz/zen27.xml (version dd08931adf98b50a6442ff1fd43f371618db5de5) (diffs)
- cpp/build/testconfigversions.cfg (version dd08931adf98b50a6442ff1fd43f371618db5de5) (diffs)
- distfiles.mk (version dd08931adf98b50a6442ff1fd43f371618db5de5) (diffs)
Peter Gebruers <peter.gebruers@gmail.com> 20 Oct 2019 24e01beeb6fc708820261a82ac1004baff4545ad

Fix test failure on build server

-Allow ozw_vers_revision to be 0
-Add -Wsign-compare to build flags
-Fix warnings caught by -Wsign-compare
- cpp/test/Makefile (version 24e01beeb6fc708820261a82ac1004baff4545ad) (diffs)
- cpp/test/ValueID_test.cpp (version 24e01beeb6fc708820261a82ac1004baff4545ad) (diffs)
- dist/openzwave.spec (version 24e01beeb6fc708820261a82ac1004baff4545ad) (diffs)
petrovcicklemen <petrovcic.klemen@gmail.com> 20 Oct 2019 fd666b29e83f028c7189eda6122ad50bee43d6fd

Added the configuration file for the Qubino LUXY Smart Light device (#1986)
- config/manufacturer_specific.xml (version fd666b29e83f028c7189eda6122ad50bee43d6fd) (diffs)
- config/qubino/ZMNHQDx.xml (version fd666b29e83f028c7189eda6122ad50bee43d6fd) (diffs)
- cpp/build/testconfigversions.cfg (version fd666b29e83f028c7189eda6122ad50bee43d6fd) (diffs)
- distfiles.mk (version fd666b29e83f028c7189eda6122ad50bee43d6fd) (diffs)
Peter Gebruers 17 Oct 2019 acce060e219385a52bf6cf03d9d6470050cd543c

MultiChannel code: change wording instance -> endpoint (#1976)

Wherever posible, voriables, comments and log suggesting "instance" have been renamed to "endpoint". There is no functional change. It improves readability of the code.

Rationale:

When dealing with MultiInstance Devices, OpenZWave uses "Instance" to identify a subdevice. The public interface maps an Instance ID to an "End Point", which in turn gets used to build Z-Wave packets.
Config files and by extension ozwcache store this map per CC, for example:

<Instance index="1" endpoint="1" />

The Group aka Association commands, however, expect "End Points".
It would make sense to change "Instance" to "End Point" in *all* related code but this is not possible, there is one exception: InstanceAssociation is exposed by the API, in Manager::GetAssociations. Because of its exposure, m_instance cannot be renamed to m_endPoint without breaking existing code.
- cpp/src/Group.cpp (version acce060e219385a52bf6cf03d9d6470050cd543c) (diffs)
- cpp/src/Group.h (version acce060e219385a52bf6cf03d9d6470050cd543c) (diffs)
- cpp/src/Manager.cpp (version acce060e219385a52bf6cf03d9d6470050cd543c) (diffs)
- cpp/src/Manager.h (version acce060e219385a52bf6cf03d9d6470050cd543c) (diffs)
- cpp/src/command_classes/MultiChannelAssociation.cpp (version acce060e219385a52bf6cf03d9d6470050cd543c) (diffs)
- cpp/src/command_classes/MultiChannelAssociation.h (version acce060e219385a52bf6cf03d9d6470050cd543c) (diffs)
Peter Gebruers 17 Oct 2019 8bd071ff571d26ebe3407ac3c61c267a26935ec9

Fix "make test" (#1979)

Edit Makefile to clarify "make test" must be run in root of repository.
Add c++11 flag en link resolv library.
Re-enable equality test in cpp/test/ValueID_test.cpp.
- .gitignore (version 8bd071ff571d26ebe3407ac3c61c267a26935ec9) (diffs)
- cpp/test/Makefile (version 8bd071ff571d26ebe3407ac3c61c267a26935ec9) (diffs)
- cpp/test/ValueID_test.cpp (version 8bd071ff571d26ebe3407ac3c61c267a26935ec9) (diffs)

Build: #77 failed Changes by 18 people

Stages & jobs

X86_64 Build

Code commits

qt-openzwave

Justin Hammond 03 Jan 2020 05b0ebad7fe016d5541b2c5f6184d9d05072a803

Justin Hammond 03 Jan 2020 9d3cb64f639bee9bdbac4640efb59e1ff5cf062e

Justin Hammond 03 Jan 2020 5e94ec5d2784dc59e3ee4e2097d1b36f3e9583f2

Justin Hammond 01 Jan 2020 ae26313469f25131f91704fccc84bcb78235dbb3

Justin Hammond 01 Jan 2020 afbc7664e824619d4e459a0b4050e42ed8c8c296

Justin Hammond 01 Jan 2020 0c904c8b601133f7f5ddce578f44e05324d484e9

Justin Hammond 01 Jan 2020 32a95b156d6b73d43f8890347d81d5300651dfd1

Justin Hammond 01 Jan 2020 991fd0be2cb5f5ce9ae540fb0273b3935ae20d1b

Justin Hammond 01 Jan 2020 cc2eb139a7e824af461df14ea4df10be3b1ea8c1

Justin Hammond 01 Jan 2020 b595fc99adab4ecd8a5500c5d5c83b01ba43171a

Justin Hammond 01 Jan 2020 4c0b42080a0884416d41457b9fa85faaaf40d96a

Justin Hammond 01 Jan 2020 a034e60b3406523b5ffcf6068d2cef05049ec4ff

Justin Hammond 01 Jan 2020 4c7a0c3b06ae0f50fa17e7019c27b08578e6ab81

Justin Hammond 01 Jan 2020 785de2abc30578a29b1b96597c2829a54168e202

Justin Hammond 01 Jan 2020 626a6c303b2cc82a92f09c542b1508ab5c53e5c5

Justin Hammond 01 Jan 2020 af482c1d422b9dff68207506ce67004b11190e6a

Justin Hammond 31 Dec 2019 b6984084a0277f5028db0b1018c2491da3cea28c

Justin Hammond 31 Dec 2019 4424fcfa0816ad7ad062e43c5626d6db750e43f3

Justin Hammond 31 Dec 2019 6cb3c1e338a6362afb335b3ecbc9d71c37eadf73

Justin Hammond 31 Dec 2019 a9b05338536082aaedbcba9d8787bd7ec986e9f9

Justin Hammond 31 Dec 2019 5daa58db6a3a7e76bdc0ac521e5308226cd3a7a6

Justin Hammond 29 Dec 2019 d8ea87468e7bb14aa3998c4b18874183eeacc009

Justin Hammond 29 Dec 2019 d6634e833e34eb649e1a8ca070b42ab9f45e5137

Justin Hammond 29 Dec 2019 450bc17b2b7544ed0606b24e84bfde09974e6693

Keith Pine <keith.pine@gmail.com> 29 Dec 2019 4b5c3cc40a3c262339ce97e80fcd9a041b35ad5b

Justin Hammond 27 Dec 2019 c970e3d081aef160a24ece88c5def8e10ff76117

Justin Hammond 27 Dec 2019 a18fc443bf6cc0e881c7f612a4cf7e580291cb81

Justin Hammond 27 Dec 2019 9826d80f73a9328b37a43e20486e753401ba1f23

Justin Hammond 27 Dec 2019 b6fdb56effb974b10eee7149eab8feaf977df47a

Justin Hammond 04 Dec 2019 e0f7cb9410b86cd43d9d6e9895619db789d53316

Justin Hammond 03 Dec 2019 8c8da7fc03abfeff5101f7f89f79706bcaf5eea5

Justin Hammond 03 Dec 2019 04440c3929899ba9eb202db9184737ec8683ee14

Justin Hammond 26 Nov 2019 dbe644e29a86609622f39dfbbbef984a83c96e79

Justin Hammond 25 Nov 2019 bf27e02bd70b7bce316bbc54afbf37aa0a5d14f4

Justin Hammond 25 Nov 2019 5ed756376c8ed9477ec0d02f6bb39c90d98a82ee

Justin Hammond 23 Nov 2019 c08ef473490d02283c13cf70d21bb1e4ee5cd4c3

Justin Hammond 23 Nov 2019 329248ac8d04a48a8d033d66f6d968dd70f30456

Justin Hammond 16 Nov 2019 326df3464cf2eb72266a35e4017ce5dbca41029a

Justin Hammond 16 Nov 2019 1c0afb8035be5e1d6077b7ac3df692ffe381d783

Justin Hammond 14 Nov 2019 993341bcc2102d5cf30e85b72ac86018e22b75f2

Justin Hammond 13 Nov 2019 910ac8c39a3ed7ad67072dc50527174870cb53d7

Justin Hammond 13 Nov 2019 7095f863f4df1af04d0437cdafe1f776ed17b434

Justin Hammond 12 Nov 2019 f8e01864d8d5e9693137ce5313a6f91917762004

Justin Hammond 12 Nov 2019 77f792cb001702b6f84fd40439c41c9e6834e1d2

Justin Hammond 12 Nov 2019 69a6cfb0d09618f10c9cedc0e6192de9d4fd6018

Justin Hammond 12 Nov 2019 663c93599b4c697ca69bec51a99adae37e22c898

Justin Hammond 12 Nov 2019 0902d61c19c724ccde6b11be60ff8dddbe0095a9

Justin Hammond 12 Nov 2019 701a0510dc563b516991d80f4b127ee9d8b600b6

Justin Hammond 12 Nov 2019 2dc6dac198b26635627ebfa9079cb15d631d6d87

Justin Hammond 12 Nov 2019 4bf8bde518d874537c22fd8f4fba04c197435145

Justin Hammond 11 Nov 2019 201b624c4413b744ed036c9a9e440f88904dd065

Justin Hammond 11 Nov 2019 0101ae4547ff5a884121d41ddeae21685c2a8921

Justin Hammond 10 Nov 2019 d634d95c45f5db43b8ffdbb3c6d3c1c2d73dfef1

Justin Hammond 07 Nov 2019 f805d596dcdd63b08f95a49419151ac1fa936b09

Justin Hammond 07 Nov 2019 d79f4a7523c3db85d4384b5fcfa05f9357ac03b3

Justin Hammond 07 Nov 2019 253f35cc0a316f5c361a21a91e4c696175a7994f

Justin Hammond 07 Nov 2019 6a057abddc8381259fffa14809493fa62dcc9049

Justin Hammond 07 Nov 2019 973e8b1ef91cebfe4f2875746e3b7f5aaf6cad21

Justin Hammond 07 Nov 2019 9746a8f6004ba2e589a303c7007dbd4245fd389f

Justin Hammond 06 Nov 2019 fa938304caee8b5018e6ece625fd78b6b7285268

Justin Hammond 06 Nov 2019 9260ae5a57f1a1ef5236dd2bb2dfbc776e2fdf31

Justin Hammond 06 Nov 2019 ed26e744486f7bcd64adbbce7131c8388bf3fc88

Justin Hammond 06 Nov 2019 5e1b41e21260ecbb46a2f00b7e86fd36865345af

Justin Hammond 06 Nov 2019 3d7c8db9e4a46d65a1c3960c3274d7cb65db1464

Justin Hammond 06 Nov 2019 6389e1a0e69e599e23e1ff900fe4ba13cd4458d6

Justin Hammond 06 Nov 2019 2b351cf6bfa48d8a22a60e62d400ea0a760f620b

Justin Hammond 05 Nov 2019 5e25c94bc0fed68c2bf456fec7d38450c416baef

Justin Hammond 05 Nov 2019 ce0022e4d28cf2c31092d748eb329369a658b72c

Justin Hammond 05 Nov 2019 5078f38accb2df397185a7f85985fc5ae2e3791d

Justin Hammond 04 Nov 2019 9c9f039dc3c391aea1cfa1784aa1cc2e98ed8247

Justin Hammond 04 Nov 2019 fe7daab975dc61ccdac85e28a772bd6e40a007a2

Justin Hammond 03 Nov 2019 6a088c931bbbb485661fafe1dc4b4e8fbd6e3c49

Justin Hammond 03 Nov 2019 ea376a48cd764cd373cda0231ccc9efbddb090c5

Justin Hammond 03 Nov 2019 8aaa26aa286955c87cae2fa4b9c6be6fda7c5148

Justin Hammond 30 Oct 2019 d3ac01e6d8075e23aa8c14d8a01547d808f59370